Login problem

[kiwi]

i get a login code, and i modified it to fit my project, i can use it. I can login , but after i login , this error message show in the page:

Warning: session_register(): Cannot send session cookie - headers already sent by (output started at c:\inetpub\wwwroot\opbs\member.php:1) in c:\inetpub\wwwroot\opbs\member.php on line 20

Warning: session_register(): Cannot send session cache limiter - headers already sent (output started at c:\inetpub\wwwroot\opbs\member.php:1) in c:\inetpub\wwwroot\opbs\member.php on line 20

If i delete the session_register() function, there will no error and at the same time , i can't login also when i key in the right details

So what is the problem? help me please? !!
thanks

[WiZARD]

as i see: headers already sent
what exactly at the c:\inetpub\wwwroot\opbs\member.php on line 20
meby better see what code above?

[ruturajv]

DO NOT OUTPUT ANY HTML OR WHITESPACES before session_start() and all session related func.

[kiwi]

the member.php code is this:

<style type="text/css">
<!--
body {
background-color: #E6E6E6;
}
-->
</style><?

// include function files for this application
require_once("bookmark_fns.php");
//session_start();

if ($username && $passwd)
// they have just tried logging in
{
if (login($username, $passwd))
{
// if they are in the database register the user id
$valid_user = $username;
session_register("valid_user");
main();
}
else
{
// unsuccessful login
do_html_header("Problem:");
echo "You could not be logged in.
You must be logged in to view this page.";
do_html_url("login.php", "Login");
do_html_footer();
exit;
}
}

do_html_header("Home");
check_valid_user();
// get the bookmarks this user has saved
if ($url_array = get_user_urls($valid_user));
display_user_urls($url_array);

// give menu of options
display_user_menu();

do_html_footer();

?>

the bold section is the line 20th. can some one help me to correct the error to prevent the error message mention previous section to show up,, thanks

[swirlee]

ruturajv's advice was correct.

[kiwi]

how? i dont really understand, can u just correct the mistake and post it here so i can have a look, please, thanks

[swirlee]

He said you can't have any output (that means text, HTML, echo statements, or includes that have the above) in the code before the session functions. So to fix your code, you have to make sure your session functions are in the code before any such output.

[ruturajv]

should be something like this

Code: Select all

<?php

// include function files for this application
require_once("bookmark_fns.php");
session_start();

if ($username && $passwd)
// they have just tried logging in
{
if (login($username, $passwd))
{
// if they are in the database register the user id
$valid_user = $username;
session_register("valid_user");
main();
}
else
{
?>
<style type="text/css">
<!--
body {
background-color: #E6E6E6;
}
-->
</style>
<?php
// unsuccessful login
do_html_header("Problem:");
echo "You could not be logged in.
You must be logged in to view this page.";
do_html_url("login.php", "Login");
do_html_footer();
exit;
}
}

do_html_header("Home");
check_valid_user();
// get the bookmarks this user has saved
if ($url_array = get_user_urls($valid_user));
display_user_urls($url_array);

// give menu of options
display_user_menu();

do_html_footer();

?>