I'm new to php programming and I wrote a code but I'm not sure whether or not I'm opening a door to hackers realy.
I use Prestashop, a open source cart to manage a online store. Because I want quickly access and alter its database, I created a .php file seems to do the trick. But how secure is it? In order to make it secure I used the login.php, and index.php files from the opensource cart; and if the e-mail and pass are ok, then it redirects to my own php file.
The user is redirected to a login.php file which suppose to be safe since is written by Prestashop; then the login.php redirects the user to index.php. The following is the index.php file
Code: Select all
<?php
define('_PS_ADMIN_DIR_', getcwd());
define('PS_ADMIN_DIR', _PS_ADMIN_DIR_); // Retro-compatibility
include(PS_ADMIN_DIR.'/../config/config.inc.php');
include(PS_ADMIN_DIR.'/functions.php');
include(PS_ADMIN_DIR.'/init.php');
@ini_set('display_errors', 'on');
//everything that is above suppose to be safe because is the login part of opensource cart
//next comes my own code
echo '
<!DOCTYPE html>
<html>
<head>
</head>
<body>';
?>
<!-- a form with a single input that takes a number (length is 13)-->
<form method="post" action="<?php echo $PHP_SELF;?>">
Scaneaza eticheta EAN13:<input type="text" id="my_input" size="20" maxlength="13" name="EAN"><br />
<input type="submit" value="submit" name="submit" style="display:none;">
</form>
<?php
$EAN = $_POST["EAN"];
if (!isset($_POST['submit'])) { // if page is not submitted to itself echo the form
//echo "<p>never submited<br /></p>";
} else {
$result = mysql_query("SELECT * FROM ps_product WHERE ean13=$EAN");
$attr=0;
$ean_valid=1;
if(!($row = mysql_fetch_array($result)))
{
$result = mysql_query("SELECT * FROM ps_product_attribute WHERE ean13=$EAN");
if($row = mysql_fetch_array($result)) {
$attr=1;
}
else
{
$ean_valid=0;
}
}
if ($ean_valid==1) {
$qty = $row['quantity'];
$id_prod = $row['id_product'];
if ($qty>0) {
$qty=$qty-1;
if ($attr==0) {
mysql_query("UPDATE ps_product SET quantity = $qty WHERE ean13 = $EAN");
}
else
{
mysql_query("UPDATE ps_product_attribute SET quantity = $qty WHERE ean13 = $EAN");
$result = mysql_query("SELECT * FROM ps_product WHERE id_product=$id_prod");
$row = mysql_fetch_array($result);
$qty2=$row['quantity']-1;
mysql_query("UPDATE ps_product SET quantity = $qty2 WHERE id_product = $id_prod");
}
echo $EAN." decremented, new quantity: ".$qty."<br />";
$file='good_sound.wav'; echo "<embed src =\"$file\" hidden=\"true\" autostart=\"true\"></embed>";
}
else
{
echo "OUT OF STOCK! Quantity is: ".$qty."<br />";
$file='bad_sound.wav'; echo "<embed src =\"$file\" hidden=\"true\" autostart=\"true\"></embed>";
}
}
else
{
echo "EAN code not found!<br />";
$file='bad_sound.wav'; echo "<embed src =\"$file\" hidden=\"true\" autostart=\"true\"></embed>";
}
}
?>
<br />
<a href="index.php?logout">Logout</a>
</body> </html>
Does anybody think I'm inviting a hacker if I use this on my server?
Thanks
