I can't for the life of me see whats wrong with this

[Mh_0]

heres the code

if ($saveuser) {
include('ukors_adminconnect.php');

$sql = "UPDATE Passwords SET `username`='$username'";
$result = mysql_query($sql);

$result = mysql_query("SELECT * FROM Passwords ORDER by username ASC" ,$db);
while ($myrow = mysql_fetch_array($result)) {
if ($myrow[username] == $username) {
if ($password <> '$myrow[password]') {
$salt = substr($password, 0, 2);
$encrypted_pswd = crypt($password, $salt);
$sql = "UPDATE Passwords SET `password`='$encrypted_pswd'";
$result = mysql_query($sql);
};
};
};

The error is:

Warning: Supplied argument is not a valid MySQL result resource in /local/data/www/htdocs/OED/CruisePlan/users.php on line 82

line 82 is:

while ($myrow = mysql_fetch_array($result)) {

(just a note I can't turn off warnings in php.ini)

anybody got any ideas?

Thanks in advance!

[Redcircle]

sounds dumb but make sure your fields in your database are spelled correct and that you are trying to access the correct database. Usually if the query has an error in it you will receive that error.

[Nehle]

Shouldn't it be

Code: Select all


while ($myrow == mysql_fetch_array($result)) {


otherwise it wouldn't be a boolean statement, right?[/code]

[Hurkle]

I think your fetch array call is fine, and now, it shouldn't be ==, it's right as it is.

This might be the problem.. the line you have is..

$sql = "UPDATE Passwords SET `password`='$encrypted_pswd'";

I would instead try..

$sql = "UPDATE passwords SET password = '" . $encrypted_pswd . "'";

a couple of things here.. your field password had single quotes around it in the sql string, I've never seen that before. Also, when building sql strings, I've had the best luck with concatenating , i.e. string = "something" . $variable . "something else", rather than having the variable inside a double quoted string expression.

Last but not least, you might want to consider some different naming conventions to avoid confusion, and eliminate case as a possible error source.. for example, if you have a table object dealing with passwords, you might use tbl_passwords as a name. The field storing the password might be fld_password. all lowercase, with underscores instead of spaces, and a naming convention for objects and variables can simplify the process.

Ok, I rambled, please give the sql string a shot and let us know if it makes a difference.. best of luck.

[ppera]

LOL